Disable eslint no-bitwise for mock timer delay check #5992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5992 +/- ##
=======================================
Coverage 64.38% 64.38%
=======================================
Files 217 217
Lines 8300 8300
Branches 3 4 +1
=======================================
Hits 5344 5344
Misses 2955 2955
Partials 1 1
Continue to review full report at Codecov.
|
SimenB
approved these changes
Apr 15, 2018
|
Stuff like this doesn't have to be in the changelog, IMO 🙂 Thanks for following up! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request contains follow up ESLint fix for #5966
code grep did show that eslint has been also disabled also in other places in jest code for sepcial cases - i guess this one will counter one?
/cc @SimenB @AhnpGit
Test plan
run linter>
yarn lint